Accept zero-padded segments in IPv6 addresses #4367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 21, 2025
Changes in cloud_controller_ng:
- Accept zero-padded segments in IPv6 addresses
PR: cloudfoundry/cloud_controller_ng#4367
Author: Sven Krieger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
With #4318 we added support for IPv6 addresses for ASGs. This PR removes the check
no_leading_zerosfor IPv6 adresses, as they are also valid and should be accepted.An explanation of the use cases your change solves
Links to any other associated PRs
IPv6 tracking issue: cloudfoundry/community#1107
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests