Skip to content

Conversation

@npaun
Copy link
Member

@npaun npaun commented Dec 18, 2025

I pasted in an old get_bcr_version() function I did last summer, and then asked Claude to implement the rest of the logic to implement bazel_dep directives.

Note that this still doesn't handle cases where we have bazel_dep + archive_override, or other kinds of overrides. Initially, this was going to be trivial, but we had to create a module extension to inject our proxy for the internal repo, so we cannot literally have update-deps.py generate that syntax anymore. I'll need to do some tinkering when I get back from vacation to force Bazel to accept this.

@npaun npaun requested a review from fhanau December 18, 2025 21:06
@npaun npaun requested review from a team as code owners December 18, 2025 21:06
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@npaun npaun force-pushed the npaun/auto-bazel-dep branch from 5c3897a to 54bdd07 Compare December 18, 2025 21:08
# Not pulling in platforms via bzlmod causes issues with the Windows clang-cl toolchain
bazel_dep(name = "platforms", version = "1.0.0")

# While the build should succeed with the default toolchain configuration from rules_cc,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did these comment go?

"type": "bazel_dep",
"freeze_version": "20250814.0"
},
// Not pulling in platforms via bzlmod causes issues with the Windows clang-cl toolchain
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig Claude moved them here as requested

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 18, 2025

CodSpeed Performance Report

Merging #5727 will not alter performance

Comparing npaun/auto-bazel-dep (3ab73de) with main (8f3a2c1)

Summary

✅ 57 untouched
⏩ 34 skipped1

Footnotes

  1. 34 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants