-
Notifications
You must be signed in to change notification settings - Fork 495
Automatically update bazel_dep(...) dependencies #5727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The generated output of |
5c3897a to
54bdd07
Compare
| # Not pulling in platforms via bzlmod causes issues with the Windows clang-cl toolchain | ||
| bazel_dep(name = "platforms", version = "1.0.0") | ||
|
|
||
| # While the build should succeed with the default toolchain configuration from rules_cc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did these comment go?
| "type": "bazel_dep", | ||
| "freeze_version": "20250814.0" | ||
| }, | ||
| // Not pulling in platforms via bzlmod causes issues with the Windows clang-cl toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anonrig Claude moved them here as requested
CodSpeed Performance ReportMerging #5727 will not alter performanceComparing Summary
Footnotes
|
I pasted in an old
get_bcr_version()function I did last summer, and then asked Claude to implement the rest of the logic to implementbazel_depdirectives.Note that this still doesn't handle cases where we have
bazel_dep+archive_override, or other kinds of overrides. Initially, this was going to be trivial, but we had to create a module extension to inject our proxy for the internal repo, so we cannot literally haveupdate-deps.pygenerate that syntax anymore. I'll need to do some tinkering when I get back from vacation to force Bazel to accept this.