-
Notifications
You must be signed in to change notification settings - Fork 353
feat(clerk-js): Introduce CSS variable support within appearance prop #6064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
02c0c5f
to
a0006a9
Compare
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
a0006a9
to
fedf717
Compare
fedf717
to
de26343
Compare
…n and update related functions to use it
de26343
to
f7ebfcc
Compare
Description
Replace JS color manipulations with native CSS color-mix to enable the use of CSS variables within appearance prop.
In the following example, brand is a hex value, but any CSS color format would be supported.
Example generated CSS: https://codepen.io/alexcarpenter/pen/PwqbrpE?editors=0100
This makes it so that folks can easily switch between light and dark themes.
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change