Skip to content

Update test GA workflow for more consistent style #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2021
Merged

Update test GA workflow for more consistent style #697

merged 2 commits into from
Nov 19, 2021

Conversation

staticdev
Copy link
Contributor

@staticdev staticdev commented Nov 18, 2021 •
edited
Loading

Just some minor changes to keep consistency:

  • Added missing quotes for python versions
  • Changed setup from Python 3.9 to 3.10
  • Changed description of setup removing python version, as in release workflow.

@cjolowicz cjolowicz added the ci Continuous Integration label Nov 19, 2021
cjolowicz
cjolowicz approved these changes Nov 19, 2021
View reviewed changes
Copy link
Owner

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Reminder for myself: The quotes around os values exceeded the line length limit, causing prettier to wrap the lines for some matrix entries.

@cjolowicz cjolowicz merged commit bb0a00a into cjolowicz:main Nov 19, 2021
@staticdev staticdev deleted the feature/tests-workflow-style-consistency branch November 19, 2021 09:29
@cjolowicz cjolowicz mentioned this pull request Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjolowicz cjolowicz cjolowicz approved these changes

Assignees
No one assigned
Labels
ci Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staticdev @cjolowicz