WIP: Casesensitive #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 14, 2019 22:17
This is a standard method to error when something doesn't line between the yaml and the target struct
spf13/viper#635 YAML keys are case sensitive according to the specification, Viper has historically forced lowercase to make lookups more predictable. This becomes a problem when the YAML is then exported again and the consumer is case sensitive. The Viper PR to which this sets the module to seems to resolve this.
Member
|
My hope is that spf13/viper#635 ends up getting pulled in. I tried reaching out to some folks today, but I'm not exactly sure who's maintaining the repos these days. I'm a little uneasy that there are so many PR's passing gates and not getting merged in, or that there's such little discussion on them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds modules and sets the upstream Viper version to PR #635 which allows setting a global case sensitive flag. This is required when re-exporting yaml to consumers that are case sensitive.
This PR will henceforth set case sensitivity to true.