Skip to content

Some improvement of ws client #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Some improvement of ws client #131

wants to merge 1 commit into from

Conversation

RayMMond
Copy link

@RayMMond RayMMond commented May 23, 2021 •
edited
Loading

  1. fix extra /0 when WebSocket Request Cache with trailing /0 s
  2. Remove hardcoded Request.SetBody to OnWsConnecting. so it's behavior can be overrided.

what do you think? @chronoxor

@RayMMond
1. fix extra /0 when WebSocket Request Cache with trailing 0s
4092df4 
2. Remove hardcoded Request.SetBody to OnWsConnecting, allowing override.
chronoxor added a commit that referenced this pull request May 23, 2021
@chronoxor
Some improvement of ws client #131
f8e914e
@chronoxor
Copy link
Owner

Fixed

@chronoxor chronoxor closed this May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RayMMond @chronoxor