Skip to content

Conversation

@pebender
Copy link
Contributor

There is a clippy warning about being explicit for some lifetimes. They must have added this relatively recently to the compiler as I am running across them in a lot of code.

@djc
Copy link
Member

djc commented Oct 11, 2025

CI failure, needs some regeneration. (Nit: this is not actually a clippy warning, but a compiler one.)

@pebender
Copy link
Contributor Author

Well, this is a mess. The reason for the problem is that the generator code creates a different output with no changes to the code. The test generates the pure rust locales file and compares its checksum with the checksum of existing pure rust locales file (src/lib.rs). Therefore, for this test to pass, src/lib.rs must be updated. However, updating this file so the test passes for this change is a update that doesn't make sense to me as the change to fix the clippy/rustc warning has no impact on the output of the generator.

I think the best thing for me to do is to create a pull request the just updates src/lib.rs so that it matches what the existing code would generate in today's environment. In addition, I think it would be good to add Cargo.lock to git so that when the same generator produces different output, we have a chance to find out why. What do you think?

@djc
Copy link
Member

djc commented Oct 14, 2025

See #18.

@djc djc closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants