strftime: simplify error handling

[djc]

Fixes #1725.

[Copilot]

Pull Request Overview

This PR simplifies error handling in the strftime module by refactoring the error handling logic to be more straightforward and adding a regression test for issue #1725.

• Simplified error handling by refactoring the error method to use cleaner parameter passing
• Restructured code organization by moving static constants and the Iterator implementation to the end of the file
• Added a regression test to prevent infinite loops in strftime parsing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/format/strftime.rs	Refactored error handling logic, reorganized code structure, and added regression test
Cargo.toml	Version bump from 0.4.41 to 0.4.42

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The error handling logic is incorrect. When there's a premature end of string, remainder is empty, but the error method expects the remaining string to calculate the consumed portion. This should pass an empty string slice or handle the case differently.

Suggested change

	None => return Some((remainder, self.error(original, remainder))), // premature end of string
	None => return Some((&original[original.len()..], self.error(original, &original[original.len()..]))), // premature end of string

[Copilot]

The error method calculation original.len() - remainder.len() can panic if remainder is not a substring of original or if there are UTF-8 boundary issues. This should use proper string slicing methods that account for the relationship between the strings.

Suggested change

	true => Item::Literal(&original[..original.len() - remainder.len()]),
	true => Item::Literal(
	original.strip_suffix(remainder).unwrap_or(""),
	),

[codecov]

Codecov Report

❌ Patch coverage is 94.69697% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (757a8b0) to head (30e8399).
⚠️ Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
src/format/strftime.rs	94.69%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   90.79%   90.88%   +0.08%     
==========================================
  Files          39       39              
  Lines       16254    16223      -31     
==========================================
- Hits        14758    14744      -14     
+ Misses       1496     1479      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.