chore: add #[inline] to num_days
#1627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
temporarily deployed
to
Coverage
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
=======================================
Coverage 91.12% 91.12%
=======================================
Files 37 37
Lines 17137 17137
=======================================
Hits 15616 15616
Misses 1521 1521 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Nov 11, 2024
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Thanks.
The wasm test failure is unrelated, so ignoring that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the code, I noticed something.
All
num_*funktions (which do the same thing, but for other divisors) are marked#[inline], except fornum_days.=> it looks not marking this method as
#[inline]is a mistake.