Skip to content

Conversation

@pitdicker
Copy link
Collaborator

@pitdicker pitdicker commented Feb 14, 2024

We use Duration in a test on Windows. This is fine because Duration is an alias of TimeDelta, but I had to switch it to TimeDelta to make the merge with 0.5.x. Better be consistent and use TimeDelta everywhere.

This also fixes one Clippy warning in the Windows module, and sets up our CI to lint the Windows target. Apparently our CI wasn't doing that, despite --all-targets.

@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (21343be) 91.86% compared to head (92c227e) 91.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1441   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files          40       40           
  Lines       17471    17471           
=======================================
  Hits        16049    16049           
  Misses       1422     1422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker force-pushed the windows_fixes branch 2 times, most recently from 3c6a5a4 to 9d9d0b3 Compare February 14, 2024 13:00
@pitdicker pitdicker marked this pull request as ready for review February 14, 2024 13:08
@pitdicker pitdicker merged commit e2e0dfe into chronotope:main Feb 14, 2024
@pitdicker pitdicker deleted the windows_fixes branch February 14, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants