test(tables): update tests after changes on lipgloss

[andreynering]

• Follow-up of feat(table): improve sizing and behavior: wrap by default, overflow optionally lipgloss#479

This PR is basically to just update the tests to make them pass, as there are some small differences with the new table work.

Before merging:

• Wait for feat(table): improve sizing and behavior: wrap by default, overflow optionally lipgloss#479 to be released and then pin the release on go.mod instead of a specific commit.

[bashbunni]

If I run these in ansi with go test ./... all tests pass, but when I use the -run directive, they fail 🤔 It seems that it's adding a selected row style to the first row by default when I run go test -run TestRendererIssues

vs

[bashbunni]

Just added a commit that fixes the issue I reported above

[bashbunni]

It looks like we're still adding extra lines between rows. There should also be ellipsis if we're cutting content (see Architectures column). I think we updated the test data though, so tests are passing

Test outputs

TestRendererIssues/44

Expected:

Got:

[andreynering]

Thank you @bashbunni!

I disabled content wrapping, which ensures we're having the same behavior as before, but with the fix of showing the ellipsis now as opposed to just cutting the content.

[bashbunni]

In v0.7.0 content wrapped by default. I just added a commit to wrap the table content by default and add some default margins which should get overridden by custom styles if some are given (will double check)

However, it seems the ANSI escape sequences aren't closing properly with wrapped content. I'm going to double check with a test on the Lip Gloss side to see if this is an issue with the new wrapping behaviour or not

PS: I updated some golden files based on outputs from v0.7.0 when we were using the tablewriter package https://github.com/olekukonko/tablewriter. We can update the golden files once we sort out this style wrapping stuff

Side note: I'm not sure if glamour is doing anything with the Conceal directive that you can set in styles. One idea I had for rendering links in the table is just to conceal the URL in the table and only display LinkText, then add all links underneath the table so you can actually click them.

[bashbunni]

Just checked in Lip Gloss and was able to reproduce this. Added a test TestTableWithLinks that showcases this behaviour

[bashbunni]

Using cellbuf.Wrap from charmbracelet/x fixes this issue. Already added that to the Lip Gloss PR that will fix this stuff.

The only thing left is to make sure that headers show "…" if the content needs to truncate

[andreynering]

After update:

@aymanbagabas A potential improvement to x/cellbuf would be to avoid breaking ponctuation characters like . , ; etc. Not sure if we want to block a release just because of this, though.

[aymanbagabas]

After update:

@aymanbagabas A potential improvement to `x/cellbuf` would be to avoid breaking ponctuation characters like `.` `,` `;` etc. Not sure if we want to block a release just because of this, though.

Could you expand on this?

One issue I see is stripping white space characters at the end and beginning of the wrapped content.

[andreynering]

@aymanbagabas I meant about the fact that some of the lines are starting with ,, while the whole word + the , char should have been moved to the next line.

I went to write a test case for this on x/cellbuf, but find out that it is actually working as expected for words without any formatting. I suppose that the bug is because each of the words is formatted on the example, but the following , is not. Looks like the end of the formatting is forcing the word to break?