fix: render right margin for block stack elements #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Here are a couple of images to demonstrate the spacing / padding rendered now: When setting the padding character in When updating the document background color |
jahvon
changed the title
Contributor
|
I was looking at this as well but to me it seems like we would have to use |
Contributor
Author
Co-authored-by: Maximilian Moehl <[email protected]>
jahvon
changed the title
caarlos0
approved these changes
Oct 28, 2024
|
Could someone see into merging this? It's a canonical party pooper. |
aymanbagabas
approved these changes
Nov 25, 2024
Member
|
hey, thanks for the PR, sorry for the delay on merging it :) |
BagToad
added a commit
to cli/cli
that referenced
this pull request
Mar 27, 2025
Due to charmbracelet/glamour#334, the margin used for markdown rendering has changed by a couple spaces. This corrects the relevant tests to accomodate that change.
rancorm
pushed a commit
to rancorm/cli
that referenced
this pull request
May 3, 2025
Due to charmbracelet/glamour#334, the margin used for markdown rendering has changed by a couple spaces. This corrects the relevant tests to accomodate that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug I was encountering with fixing up #324. It updates the way the block stack width is calculated. Instead of multiplying the indent and margin size, those two are added together. That seems to match how those two are used in the
MarginWriterused by most block elements.I also updated the
Headerso that it usesMarginWriterlike the other block elements (so padding and such is applied the same way)Note: This change does seem to result in a global drop in the rendered width by 1-2 spaces since we're evaluating the width and margin as 0 in most cases.
Fixes: #331