Document default word wrap of 80 in readme #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default word wrap limit changed from 100 to 80 in commit 71e8425, but this was un-documented other than a reference to the old 100 limit in `examples/custom_renderer/main.go` Remove the reference to the old 100 limit in the example file, and note the new default of 80 in the readme where it's more likely to be noticed (and corrected if the default ever changes again in the future). Fixes charmbracelet#161
mmrwoods
force-pushed
the
document-word-wrap-default
branch
from
0a7356f to
8b08292
Compare
Contributor
|
Thank you @mmrwoods! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default word wrap limit changed from 100 to 80 in commit 71e8425,
but this was un-documented other than a reference to the old 100 limit
in
examples/custom_renderer/main.goRemove the reference to the old 100 limit in the example file, and note
the new default of 80 in the readme where it's more likely to be noticed
(and corrected if the default ever changes again in the future).