feat+fix: bracketed paste in textinput + textarea, avoid ctl chars in clipboard input #214
+286
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2022
Contributor
Author
|
Need to wait until the other two PRs are merged before we can do CI on this one. |
knz
changed the title
knz
changed the title
knz
changed the title
This also fixes a longstanding bug where newlines, tabs or other control characters in the clipboard would cause the input to be corrupted on paste.
knz
changed the title
Contributor
Author
|
@muesli this is ready too. I have removed the inter-dependency with the other PR so that the order of release does not matter any more. |
Contributor
|
Hey @knz! I have tested all of the examples in the Bubble Tea repo with this PR and everything looks great! Thank you so much for this PR and contribution 🙇 |
Contributor
Author
|
Thank you! |
youyoumu
pushed a commit
to youyoumu/bubbles
that referenced
this pull request
Jan 19, 2025
youyoumu
pushed a commit
to youyoumu/bubbles
that referenced
this pull request
Jan 19, 2025
refs charmbracelet#214 Signed-off-by: Carlos A Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the fix to charmbracelet/bubbletea#404
charmbracelet/bubbletea#397
Also, informs #263.
cc @muesli @maaslalani