Improve workspace ux tolerance #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirzakhany
reviewed
Jul 13, 2025
| return nil, err | ||
| } | ||
| if len(workspaces) == 0 { | ||
| workspace := domain.NewWorkspace("New Workspace") |
There was a problem hiding this comment.
if you use domain.DefaultWorkspaceName as name then it will be by default protected from removal and edit.
See:
chapar/ui/pages/workspaces/view.go
Line 132 in 6a935d6
And
chapar/ui/pages/workspaces/view.go
Line 158 in 6a935d6
|
Thanks for the PR and fixing the issue, overall looks good, just one change would be to use the domain.DefaultWorkspace when creating the first workspace. I like the Idea of preventing deletion of active workspace. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing (ever). I like this project and want to help. Open to feedback.
Workspace existence seems important, and the ux is not very tolerant of it missing. My goal is to ensure one exists.
The lack of a workspace caused a nil deref here. This happened to me when first launching chapar, preventing usage. I replicated it with
rm -rf ~/.config/chapar/.To remedy the issue I:
Notice lack of the delete button on "New Workspace_3"