Skip to content

Conversation

vchrombie
Copy link
Member

Signed-off-by: Venu Vardhan Reddy Tekula [email protected]

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie
Copy link
Member Author

Once this PR approved and merged, I would like to send a PR to wg-d&i for the changes in CoC and wg-gmd for adding the CoC.

Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes other that the one I commented, look good to me. But it would be better that some native English speaker reviews this too.

Copy link
Collaborator

@germonprez germonprez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor grammatical comment. Otherwise, looks good. Thanks for the check.

@GeorgLink
Copy link
Member

Once this PR approved and merged, I would like to send a PR to wg-d&i for the changes in CoC and wg-gmd for adding the CoC.

That is an excellent idea!

Can you please make the requested changes by committing to the same branch this pull request was created from?

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>
@vchrombie
Copy link
Member Author

I have pushed the required changes. You can review it once whenever you are free. :)

Copy link
Contributor

@jgbarah jgbarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new changes! LGTM.

@jgbarah jgbarah merged commit e79ffe3 into chaoss:master Mar 22, 2019
@vchrombie
Copy link
Member Author

Thanks, @jgbarah. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants