Skip to content

Feature - GetResourceHandler #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jornh merged 35 commits into from
Nov 18, 2014
Merged

Feature - GetResourceHandler #610

jornh merged 35 commits into from
Nov 18, 2014

Conversation

@amaitland
Copy link
Member

@amaitland amaitland commented Nov 17, 2014

Due to a recent flood of requests around RespondWith not being implemented, I've created this PR

GetResourceHandler replaces RespondWith that was previously part of OnBeforeResourceLoad. I've also cleaned up some code related to RequestResponse

  • Split RequestResponse into a separate Response class and pass in Request as it's own param
  • Implement GetResourceHandler which allows for providing a Stream for a file.
  • Move Response into c# land

@amaitland
Split RequestResponse out into two, pass in Request as it's own param
e6aa9bc
@amaitland
Start renaming of IRequestResponse and RequestResponse class
a2bd84d
@amaitland
Move ResponseAction enum into c# land
2d4a5e3
@amaitland
Move Response class into c# land
d458a16
@amaitland
Remove RespondWith from OnBeforeResourceLoad
43d9f0d
@amaitland
Remove commented out code
5a939dd 
Add method stub for GetResourceHandler
@amaitland
Add GetResourceHandler to IRequestHandler interface
5a99b81 
Simplify OnBeforeResourceLoad to only support redirect for now
@amaitland
Implement missing method in StreamAdapter
cec8da6 
Implementation of GetResourceHandler still incomplete
@amaitland
Make ToHeaderMap static in SchemeHandlerWrapper (Needs to be moved to…
67ddabf 
… a common place in the future)

Get basic CefStreamResourceHandler compiling
Add headers and status codes to ResourceHandler
@amaitland
Add FromString method for loading ResourceHandler from string
393e790
@amaitland
Add basic example
19973de
@amaitland
Set Stream to null in StreamAdapter
0d593ba
@amaitland
Example crashes, revert to using CefStreamResourceHandler(mimeType, s…
f08ad0c 
…tream) as it's working - possibly a problem with the HeaderMap
@amaitland
Accidentally removed comment - revert
5ecf13d
@amaitland
Add missing ResponseAction::Cancel if statement
aa41e8c
@amaitland amaitland added this to the 37.0.0 milestone Nov 17, 2014
@amaitland amaitland added the cef3 label Nov 17, 2014
@amaitland amaitland mentioned this pull request Nov 17, 2014
Closed
@amaitland
Split RequestResponse out into two, pass in Request as it's own param
aac9914
@amaitland
Start renaming of IRequestResponse and RequestResponse class
5ddc383
@amaitland
Move ResponseAction enum into c# land
cb8385c
@amaitland
Move Response class into c# land
02da2d5
@amaitland
Remove RespondWith from OnBeforeResourceLoad
682c00b
@amaitland
Remove commented out code
e52a4f7 
Add method stub for GetResourceHandler
@amaitland
Add GetResourceHandler to IRequestHandler interface
215f804 
Simplify OnBeforeResourceLoad to only support redirect for now
@amaitland
Implement missing method in StreamAdapter
85c260d 
Implementation of GetResourceHandler still incomplete
@amaitland
Make ToHeaderMap static in SchemeHandlerWrapper (Needs to be moved to…
30c8cf9 
… a common place in the future)

Get basic CefStreamResourceHandler compiling
Add headers and status codes to ResourceHandler
@amaitland
Add FromString method for loading ResourceHandler from string
da16b3a
@amaitland
Add basic example
8e9c5da
@amaitland
Set Stream to null in StreamAdapter
dc9068d
@amaitland
Copy link
Member Author

amaitland commented Nov 18, 2014

Can be tested by navigating to http://test/resource/load in the Wpf.Example

jornh
jornh reviewed Nov 18, 2014
View reviewed changes
CefSharp/Response.cs Outdated
Copy link
Contributor

@jornh jornh Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header ...

Copy link
Member Author

@amaitland amaitland Nov 18, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@jornh jornh mentioned this pull request Nov 18, 2014
Closed
@jornh
Copy link
Contributor

jornh commented Nov 18, 2014

(Sweet 🎯) Success

This document is loaded from a System.IO.Stream

More C#, fewer LoC, Streams. What's not to like? Merging now!

jornh added a commit that referenced this pull request Nov 18, 2014
@jornh
Merge pull request #610 from amaitland/feature/respond-with
7dd065e 
Feature - GetResourceHandler
@jornh jornh merged commit 7dd065e into cefsharp:master Nov 18, 2014
@amaitland amaitland deleted the feature/respond-with branch November 18, 2014 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cef3

Projects

None yet

Milestone

37.0.0-pre01

Development

Successfully merging this pull request may close these issues.

2 participants

@amaitland @jornh