overriding JsDialogHandler is not hiding Javascript alerts

[kropewnicki]

my goal is to hide some javascript alerts that are popping up on my html

I have a custom JsDialogHandler with empty methods.

public class JsHandler : IJsDialogHandler
{
    public bool OnJSAlert(IWebBrowser browser, string url, string message)
    {

        return false;
    }

    public bool OnJSConfirm(IWebBrowser browser, string url, string message, out bool retval)
    {
        retval = false;
        return false;
    }

    public bool OnJSPrompt(IWebBrowser browser, string url, string message, string defaultValue, out bool retval, out string result)
    {
        retval = false;
        result="";
        return false;
    }
}

But I am still seeing javascript alerts. Is my override incorrect, or is there an issue in cefsharp JsHandler?

[jornh]

I haven't tried this out - just guessing - but have you tried with e.g.:

        return true; // <--- Tell CEF that you handled it so it should just shut up!
    }

The documentation for the upstream CEF OnJSDialog API leaves me with the impression that it would want that.

(We should really add this to the xmldocs too - iff I'm guessing right)

[kropewnicki]

@jornh changing to return true has not effect of javascript popup alerts

public class JsHandler : IJsDialogHandler
{
    public bool OnJSAlert(IWebBrowser browser, string url, string message)
    {

        return true;
    }

    public bool OnJSConfirm(IWebBrowser browser, string url, string message, out bool retval)
    {
        retval = true;
        return true;
    }

    public bool OnJSPrompt(IWebBrowser browser, string url, string message, string defaultValue, out bool retval, out string result)
    {
        retval = true;
        result="";
        return true;
    }
}

[jornh]

No, you are absolutely right. Thanks for reporting.

If you step out of your handler code into ClientAdapter.cpp

CefSharp/CefSharp.Core/Internals/ClientAdapter.cpp

Line 434 in eed4d94

return false;

you will see that your return value is simply ignored.

It always returns false. So fixing this should be quite trivial 😄 Apparently you are the first one who tried using this with the CefSharp3/master branch!

[kropewnicki]

Glad, to help.

[perlun]

@jornh, you fix? 😄

[jornh]

Yep yep yep 😃

[amaitland]

Worth implementing the rest of CefJSDialogHandler while we're at it?

[jornh]

I think we should leave that to after 31.0.0. It would be an enhancement - not an API change AFAICT?
And with the trivial fix we would be on par with CefSharp 1.

[amaitland]

Works for me 😄 It simply adds to the API.