All schemes are registered as non-standard

[alexwarren]

The is_standard parameter isn't being used in RegisterScheme, which means whatever you pass in here, all schemes are registered as non-standard.

Background: https://groups.google.com/forum/#!topic/cefsharp/Oug4eWYllkM

[perlun]

Good point! Do you have any idea about how it could be fixed?

On Monday, August 5, 2013, Alex Warren wrote:

The is_standard parameter isn't being used in RegisterScheme, which means
whatever you pass in here, all schemes are registered as non-standard.

Background: https://groups.google.com/forum/#!topic/cefsharp/Oug4eWYllkM

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/150
.

mvh,
Per Lundberg

[alexwarren]

I did spend a short while poking around, but I'm not familiar enough with CEF or CefSharp to know where this parameter is supposed to end up!

[perlun]

I don't know the details in this case either. 😄 You can try looking here: https://github.com/cefsharp/CefSharp/blob/master/CefSharp/SchemeHandler.cpp#L80

(That's the code that actually creates the SchemeHandler.)

The best chance you have for getting this fixed is to try and investigate it a bit yourself. Pull requests are welcome. It's probably (hopefully...) not that hard to fix once you find the appropriate file to modify...

It could be worthwhile poking a bit in the include/ folder, where you have all the CEF headers. There you should be able to find (again, hopefully) something related to the is_standard flag.

[alexwarren]

The only reference I can find is in cef_scheme.h, where there's a CefSchemeRegistrar which has this as its only method:

  virtual bool AddCustomScheme(const CefString& scheme_name,
                               bool is_standard,
                               bool is_local,
                               bool is_display_isolated) =0;

There's no mention of CefSchemeRegistrar anywhere in CefSharp though, so presumably it's registering schemes via a different method?

[perlun]

It seems so, yes. (I haven't written these parts myself so I consider myself by no means an expert in the area.)
We use this method for register scheme handler factories:

bool CefRegisterSchemeHandlerFactory(const CefString& scheme_name,
                                     const CefString& domain_name,
                                     CefRefPtr<CefSchemeHandlerFactory> factory);

I have no idea why it has been done like this. From what I can immediately tell, I don't know how AddCustomScheme() actually knows what class should be used to handle the custom schema, so that could be one obvious reason... 😄

Continuing writing a few seconds later...

It seems like we should probably use both: https://code.google.com/p/chromiumembedded/source/browse/trunk/cef1/tests/cefclient/scheme_test.cpp#148

(This is an "official" test client for CEF, not CefSharp, written by the CEF guys.)

As you see there, they both call registrar->AddCustomScheme() and CefRegisterSchemeHandlerFactory. I guess it works without the call to registrar->AddCustomScheme(), but obviously not with the is_standard stuff etc.

Here's what you should do if you want to fix it: In ClientAdapter (.cpp/.h), add an override of the method OnRegisterCustomSchemes. Something like this:

  virtual void OnRegisterCustomSchemes(CefRefPtr<CefSchemeRegistrar> registrar) OVERRIDE {
    // TODO: loop over all custom schemes here and add them.
    registrar->AddCustomScheme("foo", true, false, false);
  }

I'll be quite happy to merge in a PR that fixes this; it sounds like a good thing.

[alexwarren]

Unless I'm missing something, ClientAdapter doesn't inherit from a base class that has an OnRegisterCustomSchemes method. This is defined on CefApp. Does that mean ClientAdapter should include cef_app.h and inherit CefApp in addition to the other interfaces? (Kind of stumbling around in the dark here, wishing I knew C++...)

[perlun]

Ah, sorry. Maybe it's some other class that inherits from CefApp (I think
ClientAdapter is a CefClient derivative perhaps). Find that other class and
make the modifications there. (sorry, don't have time to look it up at the
moment)

On Tue, Aug 6, 2013 at 12:15 PM, Alex Warren notifications@github.comwrote:

Unless I'm missing something, ClientAdapter doesn't inherit from a base
class that has an OnRegisterCustomSchemes method. This is defined on
CefApp. Does that mean ClientAdapter should include cef_app.h and inherit
CefApp in addition to the other interfaces? (Kind of stumbling around in
the dark here, wishing I knew C++...)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/150#issuecomment-22166794
.

mvh,
Per Lundberg

[alexwarren]

Unfortunately there is nothing in CefSharp that inherits from CefApp!

[perlun]

OK. Sorry, I've been working more on the (unstable) cef3-based branch lately, and there we actually have a class that derives from CefApp. So, my conclusion is that this is a "wontfix" as far as cef1 is concerned, but we should remove that parameter to decrease the level of confusion. Patch coming up in that direction.

[perlun]

I've actually fixed this in c92d3e3 and 7b74e21. So it should be working in CefSharp3. Give it a test if you like, it works fine for me.