Support for legacy QR codes for retail has been implemented #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Dec 25, 2025
Comment on lines
+89
to
+103
| // Skip if it's already a known Lightning format | ||
| if ( | ||
| trimmed.toLowerCase().startsWith("lnbc") || | ||
| trimmed.toLowerCase().startsWith("lightning:") || | ||
| trimmed.toLowerCase().startsWith("lnurl") || | ||
| trimmed.toLowerCase().startsWith("lnurl1") || | ||
| trimmed.startsWith("bitcoin:") || | ||
| trimmed.startsWith("cashuA") || | ||
| trimmed.startsWith("cashuB") || | ||
| trimmed.startsWith("creqA") || | ||
| trimmed.startsWith("http://") || | ||
| trimmed.startsWith("https://") | ||
| ) { | ||
| return false; | ||
| } |
Collaborator
There was a problem hiding this comment.
I don't think we need this block, because where the function is called, we test all these options before the isLegacyRetailQR is called. Also it seems very odd for this function to recognize other types of payments.
prusnak
reviewed
Dec 25, 2025
| const lightningAddress = convertMerchantQRToLightningAddress(trimmedCode, network); | ||
| if (lightningAddress) { | ||
| console.log("Converted merchant QR code to Lightning Address:", { | ||
| original: trimmedCode.substring(0, 50) + "...", |
Collaborator
There was a problem hiding this comment.
why only substring here? it makes debugging harder
prusnak
requested changes
Dec 27, 2025
Collaborator
prusnak
left a comment
prusnak
left a comment
There was a problem hiding this comment.
The PR contains lots of boilerplate for other types of legacy QR codes which are not actually supported.
I would focus on handling only the EMV QR codes that start with "000201" and handle only these.
This would remove 80% of the suggested changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #485
In this pull request, I implemented support for legacy retail QR codes. I thought this was an interesting proposal and, inspired by it GaloyMoney/galoy-client#331.
I also covered the new functionality with tests to ensure the security of the code being implemented.
@prusnak @joelklabo @novascreen @Algooo @aekasitt I would be very glad if this was useful for you :)