Skip to content

Conversation

@sergeysova
Copy link
Member

Branch name

  • Your branch should be prefixed with feature/ or fix/ or chore/ or refactor/ or tests/
  • Add issue identifier
  • Add 3-5 words of description separated with -

Example:

feature/BOX-12-add-login-form
fix/BOX-8-loading-panel-on-first-load
chore/BOX-22-add-release-drafter

PullRequest

  • This PullRequest implements new feature, fix bug, or some other changes
  • If PR is not ready to review mark it as Draft
  • All commits in this PR should be created by yarn commit by conventional-commits
  • Title of the PullRequest should have issue(s) identifier(s) ("BOX-123 Example title of PR")

@sergeysova sergeysova marked this pull request as ready for review August 6, 2021 18:19
azinit
azinit previously approved these changes Aug 6, 2021
Copy link
Contributor

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пытался вникнуть - пофиг, го вольем))

Но мб пока mock-эндпоинты не отрубать, а оставить, пока не прикрутим?

@sergeysova sergeysova force-pushed the refactor/migrate-to-openapi branch from 5527d9e to aa08834 Compare August 6, 2021 20:03
@sergeysova sergeysova enabled auto-merge August 6, 2021 20:03
@sergeysova sergeysova disabled auto-merge August 7, 2021 09:05
@sergeysova sergeysova changed the title Add openapi feat: add openapi to generate API Aug 7, 2021
@sergeysova sergeysova merged commit 63b128c into master Aug 7, 2021
@sergeysova sergeysova deleted the refactor/migrate-to-openapi branch August 7, 2021 09:05
Comment on lines +24 to +27

$cards.on(getCardsListFx.doneData, (_, cards) => cards);

$currentCard.on(getCardByIdFx.doneData, (_, card) => card);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Пошла поехала машине рефакторинга))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Тож хотел on от store отделить давненько

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(забыл сабмитнуть вчера - но там ответа ждал по сути твоего)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants