Skip to content

BOX-112: user page #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
azinit merged 10 commits into from
Jul 16, 2021
Merged

BOX-112: user page #42

azinit merged 10 commits into from
Jul 16, 2021

Conversation

@asvtsv
Copy link
Contributor

@asvtsv asvtsv commented Jul 4, 2021 •
edited
Loading

BOX-112

  • Добавляет выделенную страницу пользователя

@asvtsv asvtsv requested a review from azinit July 4, 2021 19:25
azinit
azinit reviewed Jul 4, 2021
View reviewed changes
azinit
azinit reviewed Jul 4, 2021
View reviewed changes
Copy link
Contributor

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Позже еще гляну, но в целом направление мысли правильно вродь

Но это так понимаю - еще только первый этап "Подгружаем инфу по юзеру"

А след. этапы уже про - "Подгрузку личной коллекции" и "Подгрузку избранных карточек"

azinit
azinit previously approved these changes Jul 4, 2021
View reviewed changes
Copy link
Contributor

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом все ок, но я бы все же постарался на этом этапе еще - смержить страницу ЛК (viewer) с общей страницей юзера (ту которую ты сейчас сделал отдельно)

А то потом неразбериха будет)

@azinit azinit requested review from antonmazhuto and sergeysova July 4, 2021 20:13
@asvtsv asvtsv requested a review from azinit July 6, 2021 09:03
azinit
azinit previously approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В приииинципе ок, но чет ты тут начал тащить изменения для следующих итераций)

Не сильно против, чтоб вливать - но тогда моменты эти надо будет в некст итерации поправить

@asvtsv asvtsv requested a review from azinit July 6, 2021 11:04
azinit
azinit previously approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@azinit azinit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

UPD: То что отписал - некритично, но просто зацепился глаз со второго раза

@asvtsv asvtsv requested a review from azinit July 7, 2021 14:22
azinit
azinit previously approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

exuvia-dev
exuvia-dev reviewed Jul 10, 2021
View reviewed changes
@asvtsv asvtsv requested review from azinit and exuvia-dev July 12, 2021 07:17
azinit
azinit previously approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asvtsv все супер, поправь пож только конфликт с мастером)

sergeysova
sergeysova reviewed Jul 15, 2021
View reviewed changes
sergeysova
sergeysova previously requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@sergeysova sergeysova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asvtsv описывай пожалуйста кратко набор изменений в названии ПР-а
в формате "ABC-123 Краткое описание", где ABC-123 это идентификатор задачи linear.
Краткое описание поможет другим людям понять зачем ты вносишь именно такие изменения

exuvia-dev
exuvia-dev reviewed Jul 15, 2021
View reviewed changes
@azinit
Copy link
Contributor

azinit commented Jul 16, 2021

@OlegBrony @risenforces @sergeysova @dmi-ch Гляньте пож, еще один аппрув нужен)

@azinit azinit dismissed sergeysova’s stale review July 16, 2021 16:14

Ну человек поправил вродь, а мердить пора уже)

@azinit azinit merged commit a40942e into master Jul 16, 2021
@azinit azinit deleted the BOX-112 branch July 16, 2021 16:15
@sergeysova sergeysova changed the title feature/BOX-112: user page BOX-112: user page Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonmazhuto antonmazhuto Awaiting requested review from antonmazhuto

@sergeysova sergeysova Awaiting requested review from sergeysova

2 more reviewers

@azinit azinit azinit approved these changes

@exuvia-dev exuvia-dev exuvia-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asvtsv @azinit @sergeysova @exuvia-dev