BOX-65 add search page #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61
adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61
adds search ability with trigger on field change, with debounce ISSUES CLOSED: #61
babel plugin export ISSUES CLOSED: #61
added package from suggestions in review ISSUES CLOSED: #61
changing view for search page changes view of users list changes view of card list ISSUES CLOSED: #65
changed base button to match design ISSUES CLOSED: #65
history, reflect (has bugs) ISSUES CLOSED: #65
# Conflicts: # src/app/server.tsx # src/entities/card/organisms/card-preview.tsx # src/features/search-bar/models/index.ts # src/features/search-bar/molecules/search.tsx # src/features/search-bar/organisms/search-bar.tsx # src/pages/home/index.tsx # src/pages/search/model.ts # src/pages/search/page.tsx # yarn.lock
BREAKING CHANGE: missed reflect ISSUES CLOSED: #65
azinit
reviewed
Jun 25, 2021
azinit
previously approved these changes
Jun 26, 2021
Contributor
azinit
left a comment
azinit
left a comment
There was a problem hiding this comment.
В принципе выглядит правдеподобно
Но а как ты yarn починил? Теперь точно не поломает ничего?)
sergeysova
previously approved these changes
Jun 26, 2021
# Conflicts: # .gitignore # src/pages/search/page.tsx # yarn.lock
risenxxx
previously approved these changes
Jun 28, 2021
azinit
reviewed
Jun 29, 2021
azinit
approved these changes
Jun 29, 2021
risenxxx
approved these changes
Jun 30, 2021
sergeysova
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
little pr to close previous holes...
lock: yarn, package
fixed reflect