Skip to content

Conversation

@justinbmeyer
Copy link
Contributor

For canjs/canjs#4656

Dispatches events with:

action: "set",
key: prop,
target: map,
newValue: newVal,
oldValue: oldValue,

This enables:

map.on("key", ({newValue}) => {})

type functions.

Copy link
Contributor

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think this is good. I commented on a few things that I think could be cleaned up.

@matthewp matthewp dismissed phillipskevin’s stale review August 8, 2019 18:44

Changes asked for were done.

@matthewp matthewp merged commit 04881e5 into master Aug 8, 2019
@matthewp matthewp deleted the new-old-value branch August 8, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants