fix: panic on transform stream check #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
transform-panic
branch
from
37949a4 to
a6aa931
Compare
cfallin
approved these changes
Sep 10, 2024
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
This seems locally fine as a more robust check, but do we know why the slot was not a boolean? Is there a path that doesn't initialize it, or is some other value being stored there erroneously?
Contributor
Author
|
There's a lot of complex logic here and quite honestly I haven't traced it carefully, but I can verify this solves the full end to end Fastly issue in fastly/js-compute-runtime#954. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic Fastly was seeing when passing a request body to a response, where this slot was not a boolean causing a panic.