Fix #689: Original range should be remembered after toggleSection
#690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
approved these changes
Jul 16, 2019
src/js/editor/post.js
Outdated
| if (sectionTransformations.length) { | ||
| let changedHeadSection = sectionTransformations | ||
| .find(({ from }) => { return from === range.headSection; }) | ||
| .to; |
Contributor
There was a problem hiding this comment.
So this was described to me as: Walk through the changes, find the mapping which is for the same section as the old range's head, then use the mapped "to" as the new section for the head.
This seems good and like it might be a useful pattern in refactoring the range code in general.
Collaborator
Author
|
@mixonic Just realized that we didn't merge this and didn't include it in the pre-release. Are you cool merging this and then publishing a new pre-release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #689
The idea is that when toggling a section, we maintain a list of mappings from the original to the new section. Sometimes, sections are maintained but the tag name is simply modified. This happens for instance when going from a paragraph to a H1. However, sometimes sections are destroyed and a new one is created. For instance, when going from a list to a paragraph.
By looking at the mapping of old section to new section, we can reconstruct the selection after toggling:
The only edge case is when toggling to a list. There, the sections in the range have to point to ListItem's rather than ListSections. But at the time of toggling, we only have access to the ListSection, and we don't know which ListItem's the new range should point to.
Other changes