Fix UI import statement #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@joshfrench No worries. This looks right to me. I will test it out more fully later but can release a beta now. |
Collaborator
|
@joshfrench This is released on v0.10.11-beta.1 if you want to make sure it works now for you. |
Contributor
Author
|
The beta works for me, thanks and sorry for that. I just pushed another commit to this branch that exposes |
Collaborator
|
Cool, yeah, I'm pulling that in on #493. thanks! |
Collaborator
|
released in v0.10.11 |
Contributor
Author
|
Thanks Cory! |
johnelliott
pushed a commit
to dailybeast/mobiledoc-kit
that referenced
this pull request
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My bad! I botched the import on
Mobiledoc.UI. I had a bit of a challenge trying to verify this in your dev env while being unfamiliar with Broccoli and Ember, do you mind checking it before you ship this patch? Thanks!