Use "version" script instead of postversion with --amend --no-edit #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using --amend --no-edit was changing the sha of the commit *after* it had been tagged, which caused issues with future updates to the changelog. The `git-semver-commits` package failed to find tags when their commits were amended post-tagging.
bantic
added a commit
to bustle/ember-mobiledoc-editor
that referenced
this pull request
Aug 4, 2016
Using postversion was messing up the git tags by changing the sha of the commit they initially pointed to. See also bustle/mobiledoc-kit#448
Collaborator
Author
|
released in v0.10.4 |
bantic
added a commit
to bustle/ember-mobiledoc-editor
that referenced
this pull request
Aug 4, 2016
Using postversion was messing up the git tags by changing the sha of the commit they initially pointed to. See also bustle/mobiledoc-kit#448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using --amend --no-edit was changing the sha of the commit after it
had been tagged, which caused issues with future updates to the
changelog. The
git-semver-commitspackage failed to find tags whentheir commits were amended post-tagging.