Refactor postEditor#deleteRange, deprecate #deleteFrom in favor of deleteAtPosition
#442
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code path the editor took when deleting a single character (via
postEditor#deleteFrom) and deleting a non-collapsed range (viapostEditor#deleteRange) differed greatly. This PR deprecatesdeleteFromand introducespostEditor#deleteAtPosition(andEditor#deleteAtPosition). These methods almost always delegate their work todeleteRange. This allows for much simplification of the deletion code, and the improved test coverage will enable future refactorings.deleteAtPositionexpands the position by 1 unit ("char" or "word") indirection(into aRange) and deletes that range. The only exception is when the position is at the head of a list item, in which case the list item is toggled into a markup section instead.API Changes:
Editorclass. AddsEditor#deleteAtPosition.postEditor#deleteFrom.postEditor#sectionsContainedBypostEditor#deleteFromTest changes:
postEditor#deleteRange, addspostEditor#deleteAtPosition.postEditor#deleteFrompostEditor:MockEditor,runandrenderBuiltAbstract, DRYs tests to share these abstractionsHelpers.postAbstract.buildFromText. This allows creating a post and range using a text-based DSL instead of thePostNodeBuilder(see notes below)buildFromTextDSL