Fix 360 #424
Merged
Fix 360 #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify behavior for adding markups that surround, are surrounded by, or are interleaved with existing markups. Failing tests for bustle#360
Fixes bustle#360 We insert the new markup at a consistent index across the range. If we just push on the end of the list, it can end up in different positions of the markup stack. This results in unnecessary closing and re-opening of the markup each time it changes position. If we just push it at the beginning of the list, this causes unnecessary closing and re-opening of surrounding tags. So, we look for any tags open across the whole range, and push into the stack at the end of those.
Collaborator
|
CI failures seem due to unrelated issues at SauceLabs — I'm restarting them |
Collaborator
|
🎆 thanks, @courajs ! |
Collaborator
|
released in v0.9.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360
We insert the new markup at a consistent index across the range.
If we just push on the end of the list, it can end up in different positions of the markup stack. This results in unnecessary closing and re-opening of the markup each time it changes position.
If we just push it at the beginning of the list, this causes unnecessary closing and re-opening of surrounding tags.
So, we look for any tags open across the whole range, and push into the stack at the end of those.
Let me know if that isn't clear enough!
/cc @bantic