Ensure cursor positioning on a blank markup section or list item works #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantic
force-pushed
the
fix-blank-markup-section-rerenders
branch
from
955205e to
4eb0e1f
Compare
…item works
`Cursor#_findNodeForPosition` should return the cursor element ("br",
usually) for a blank section. This change also ensures that the built-in
text-expansions for list items and headers position the cursor properly.
bantic
force-pushed
the
fix-blank-markup-section-rerenders
branch
from
4eb0e1f to
9d20ed1
Compare
Collaborator
Author
|
released in v0.9.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cursor#_findNodeForPositionshould return the cursor element ("br",usually) for a blank section. This change also ensures that the built-in
text-expansions for list items and headers position the cursor properly.
See also #375 which addressed this for list-items only.