Ignore mutation events from within atoms #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ember-mobiledoc-editor uses ember-wormhole to insert components into atom placeholders. This immediately causes a mutation and then the editor update is triggered when nothing has changed. Atoms are their own world and so any changes in them should be safe to ignore. Delegates the mutation-reparsing logic to RenderNodes.
bantic
force-pushed
the
ignore-atom-mutations-via-render-nodes
branch
from
286fe07 to
8aac800
Compare
Collaborator
Author
Collaborator
Author
|
released in v0.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-mobiledoc-editor uses ember-wormhole to insert components into
atom placeholders. This immediately causes a mutation and then
the editor update is triggered when nothing has changed.
Atoms are their own world and so any changes in them should be safe
to ignore.
Delegates the mutation-reparsing logic to RenderNodes.