[CLEANUP] DRY copy/paste and drop event handling. Add editor#serializeTo #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove now-unused `supportsStandardClipboardAPI` test helper
* Add `editor#serializeTo(format)`
* Add `editor#serializePost(post, format)`
* Add deprecate helper
* Add `post#trimTo(range)` and deprecate `post#cloneRange`.
`cloneRange` returns a mobiledoc, which is confusing.
* Enable all copy-paste acceptance tests in IE. They all now use
the copy/paste mocks from the test helpers.
* Add an IE-compatibility test for `getContentFromPasteEvent` to
ensure it will use `window.clipboardData`
* Add an IE-compatibility test for `setClipboardData` to
ensure it will use `window.clipboardData`
Collaborator
Author
|
released in v0.9.1 |
Collaborator
|
@bantic Sorry for my late reply, was on a holiday last week. This looks great, thanks for enabling all tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editor#serializeTo(format)editor#serializePost(post, format)post#trimTo(range)and deprecatepost#cloneRange.cloneRangereturns a mobiledoc, which is confusing.the copy/paste mocks from the test helpers.
getContentFromPasteEventtoensure it will use
window.clipboardDatasetClipboardDatatoensure it will use
window.clipboardDatasupportsStandardClipboardAPItest helpercc @YoranBrondsema this turns on all tests in all environments. Adds IE-compatibility tests for the two methods that may interact directly with
window.clipboardData.