Ensure using arrow keys when text is selected moves cursor correctly #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where selecting text and then hitting left/right would move the cursor one character past the left/right side of the selection instead of putting the cursor *at* the left/right side of the selection. * Remove `Range#moveFocusedPosition` * Add `Range#move` and `Range#extend`, add tests for same * Refactor EventManager's `keydown` method to use `Range` `#move` and `#extend`
bantic
force-pushed
the
fix-selection-arrow-movement
branch
from
30dfef1 to
58dec72
Compare
bantic
added a commit
that referenced
this pull request
Mar 22, 2016
Ensure using arrow keys when text is selected moves cursor correctly
Collaborator
Author
|
released in v0.9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where selecting text and then hitting left/right would
move the cursor one character past the left/right side of the selection
instead of putting the cursor at the left/right side of the selection.
Range#moveFocusedPositionRange#moveandRange#extend, add tests for samekeydownmethod to useRange#moveand#extend