Add support for mobiledoc 0.3.2 #170
Conversation
lukemelia
force-pushed
the
chore/update-mobiledoc
branch
from
801c346 to
678bd8c
Compare
| let editor = this.get('editor'); | ||
| let attributeName = this.get('attributeName'); | ||
| let attributeValue = this.get('attributeValue'); | ||
| editor.setAttribute(attributeName, attributeValue); |
There was a problem hiding this comment.
I added the ability to removeAttribute in mobiledoc-kit so we can make sure to remove the attribute if the attribute is set to the default value (left). Can we incorporate that here so we don't have attributes added to things in the data when the desire is to simply go back to the browser default of left? It makes for a cleaner experience imo.
I did the same thing in the react editor: joshfrench/react-mobiledoc-editor@d7f93b3
There was a problem hiding this comment.
@ZeeJab Makes sense. I'll refine accordingly.
There was a problem hiding this comment.
Updated. I took a little different approach than in the react version. I think it is better for the editor to determine the default attribute value rather than the toolbar props.
lukemelia
force-pushed
the
chore/update-mobiledoc
branch
from
678bd8c to
98bbe43
Compare
Updates to mobiledoc-kit 0.12.4 Adds mobiledoc-section-attribute-button for building toolbars. Adds text-alignment buttons to mobiledoc-toolbar Updates README accordingly
lukemelia
force-pushed
the
chore/update-mobiledoc
branch
from
4c4eed7 to
93653e2
Compare
3 participants
Uh oh!
There was an error while loading. Please reload this page.