Added nvi to base console docker image. #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No net increase in image size: Before: $ ls -l ./dist/artifacts/burmillaos.iso -rw-r--r-- 1 brian brian 242221056 Jun 23 07:54 ./dist/artifacts/burmillaos.iso After adding nvi: -rw-r--r-- 1 brian brian 242221056 Jun 23 08:05 ./dist/artifacts/burmillaos.iso Net filesize on disk is around 476k: $ make run ... rancher@rancher-dev:~$ which vi /usr/bin/vi rancher@rancher-dev:~$ ls -l /usr/bin/vi lrwxrwxrwx 1 root root 20 Jun 23 12:01 /usr/bin/vi -> /etc/alternatives/vi rancher@rancher-dev:~$ ls -l /etc/alternatives/vi lrwxrwxrwx 1 root root 12 Jun 23 12:01 /etc/alternatives/vi -> /usr/bin/nvi rancher@rancher-dev:~$ ls -l /usr/bin/nvi -rwxr-xr-x 3 root root 476312 Dec 4 2018 /usr/bin/nvi
Author
|
This fixes issue #99 if accepted. |
olljanat
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nvi to the console base image, resulting in around 500k additional disk space used. This should hopefully not impact existing deployments too greatly.