feat: improve extension installer + updater #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shadowfax92
commented
Jan 1, 2026
shadowfax92
commented
- feat: new extension installer + bundle support
- feat: support bundle extension download in cli
- chore: update release yaml to include new bundle_extensions module
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+44
to
+45
| + ManifestLocation::kExternalPref, // CRX location (bundled) | ||
| + ManifestLocation::kExternalPrefDownload, // Download location (remote) |
There was a problem hiding this comment.
logic: Using both kExternalPref and kExternalPrefDownload as constructor arguments appears incorrect for ExternalProviderImpl. The constructor typically takes creation_flags and install_flags, not two ManifestLocation values. Are you sure the ExternalProviderImpl constructor accepts two ManifestLocation parameters in this order?
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browseros/chromium_patches/chrome/browser/extensions/external_provider_impl.cc
Line: 44:45
Comment:
**logic:** Using both kExternalPref and kExternalPrefDownload as constructor arguments appears incorrect for ExternalProviderImpl. The constructor typically takes creation_flags and install_flags, not two ManifestLocation values. Are you sure the ExternalProviderImpl constructor accepts two ManifestLocation parameters in this order?
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+133
to
+135
| + for (const auto [id, _] : last_config_) { | ||
| + extension_ids_.insert(id); | ||
| + } |
There was a problem hiding this comment.
logic: Extension IDs from remote config are added without validation - potential security risk
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browseros/chromium_patches/chrome/browser/browseros/extensions/browseros_extension_maintainer.cc
Line: 133:135
Comment:
**logic:** Extension IDs from remote config are added without validation - potential security risk
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+144
to
+145
| + base::FilePath crx_path = | ||
| + bundled_path.Append(base::FilePath::FromUTF8Unsafe(*crx_file)); |
There was a problem hiding this comment.
logic: Using FromUTF8Unsafe with external input could allow directory traversal attacks. Consider validating that crx_file contains only a filename without path separators.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/browseros/chromium_patches/chrome/browser/browseros/extensions/browseros_extension_installer.cc
Line: 144:145
Comment:
**logic:** Using `FromUTF8Unsafe` with external input could allow directory traversal attacks. Consider validating that `crx_file` contains only a filename without path separators.
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.