Handle Pool Error #3147
Merged
Handle Pool Error #3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrz
approved these changes
Sep 3, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
Tests out nicely for me. 👍
BTW @jameskerr, here's a bonus finding I spotted while I was testing this out: The radio button for "Descending" is freakishly close to the right side of the word "Ascending". I know you've often not been shy about sneaking in fixes to unrelated issues in PRs, so if you wanted to improve that here, I would not fight it. 😉
Contributor
Author
|
I'll just put up another PR for that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create a pool that already exists will now display the error instead of crashing with a runtime error.
CleanShot.2024-09-03.at.13.59.03.mp4