Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been holding off on adding Parquet as an Export format in Zui until #2751 was fixed, since there's so many Parquet limitations that can prevent the export from succeeding (e.g., lack of support for multiple types, lack of duration support, poor union support, etc.) But now that #2751 has been fixed and users will see the errors when exports fail, here I'm adding support for Parquet as an Export format.
Due to those same Parquet limitations, I could not just extend the existing loop-through-all-formats approach in the existing Export e2e test because an attempted export of that same test data file would fail. I saw a few ways this could be addressed:
I could rework the existing test to use a different, Parquet-eligible test data file for export in all formats and change all the expected byte counts to match. I chose not to pursue this since it didn't seem appropriate to "dumb down" to the lowest common denominator.
I could add an additional test just for Parquet that imports its own Parquet-eligible test data file. I took this approach in the first commit on this branch. However, I had to duplicate some code from the existing test.
Same as the prior, but I could break out the common code to a helper function that could be called by both the prior loop-through-all-formats approach as well as the new test for just Parquet. I took this approach in the second commit on this branch.
Of course, there's surely other variations, so I'm open to other adjustments.
Closes #2591