Tiny Duration Fix #3119
Merged
Tiny Duration Fix #3119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
commented
Jul 1, 2024
| if (this.r.get("_path").toString() !== "conn") return null | ||
| const dur = this.r.get<zed.Duration>("duration").asSeconds() | ||
| if (!dur) return | ||
| const dur = this.r.get<zed.Duration>("duration").asMs() |
Contributor
Author
There was a problem hiding this comment.
Use milliseconds here instead of seconds, to get the most precision we can.
jameskerr
commented
Jul 1, 2024
| } | ||
| if (allZero) { | ||
| parts.push(formatPart((end.getTime() - start.getTime()) / 1000, "seconds")) | ||
| if (end.getTime() === start.getTime()) { |
Contributor
Author
There was a problem hiding this comment.
Check if the two dates are the same to determine if the duration is less than 1ms.
philrz
approved these changes
Jul 1, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
The fix seems effective. I saw one of the tests was broken so I pushed a commit to fix it.
Contributor
Author
|
Thanks Phil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3101
With this fix:
If the duration is less than 1 second, it will display "xxxmilliseconds"
If it is less than 1 millisecond, it will display "less than one millisecond"