Skip to content

Conversation

@jameskerr
Copy link
Contributor

@jameskerr jameskerr commented Jun 20, 2024

Maybe Fixes #3105

Give this a spin @philrz

@jameskerr jameskerr closed this Jun 20, 2024
@jameskerr jameskerr force-pushed the node-fetch-is-back branch from 0e43a91 to 10d8974 Compare June 20, 2024 17:22
@jameskerr jameskerr reopened this Jun 20, 2024
Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

To test, I first confirmed that these changes bring the data load from #3105 back to the ~5 second range on my Macbook. I also reconfirmed that the Zed lake service is still only listening for connections from localhost (#3056). Finally, I started up a loop of the e2e test studied in #3063 and got through 100 successes and 0 failures before I stopped it.

Finally, in anticipation of this merging, I've reopened #3071 because per that issue there's still a possible future where we could dump the node-fetch dependency and have the reliable CI. I've put #3071 in my backlog as a reminder to keep an eye on the Electron releases and when one comes out that ships with a new enough Node version I can re-test then.

@jameskerr jameskerr merged commit 508a6ae into main Jun 20, 2024
@jameskerr jameskerr deleted the node-fetch-is-back branch June 20, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data loads seem much slower with Net Fetch

3 participants