Update CONTRIBUTING with new Windows code signing info #3055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #3050 make this part of the CONTRIBUTING doc out-of-date and in need of update.
I'm a little hand-wavy in terms of what I've written here since manual signing is surely still possible but I've never attempted it in this new world order since it would require purchasing the special FIPS/YubiKey hardware. Likewise I'm sure other signing services could be made to work just like we did with eSigner, but I have no clue if they're similar/easy/hard. Therefore I've chosen to effectively point at what we've done with eSigner as a reference, leave it up to the reader to make it work for their alternatives, and invite them to share what they learned since it might help others (or us if we need to switch approaches in the future).
Ultimately I'm guessing most community members aren't signing builds so maybe this is all moot, but at least we're not pointing at stuff that won't work anymore. 😄