Run pool load e2e tests in CI again #3033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
approved these changes
Mar 28, 2024
Contributor
jameskerr
left a comment
jameskerr
left a comment
There was a problem hiding this comment.
Hell yeah! Thank you for your thorough testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #2972 made it such that our e2e tests now have a reliable way to check query results. In #2972 (comment) I did some preliminary verification that this change was having the intended benefits, and that includes some baselining of how bad the problem was before and hence reminded us why we'd been skipping the "pool load" tests in CI. Now that #2972 is merged, in this PR I've banked that improvement by breaking out the e2e pool loads tests that are now reliable into their own set that we can run again in CI, while a separate test that remains unreliable is now broken out separately and is still skipped in CI (addressing that is tracked in #3021).
To verify, I did an Actions run on this branch with these changes in place (since reverted) to run this set of
pool-load-successtests in a loop on all platforms. As the results show, it ran successfully through all 1000 runs on both macOS and Windows without a single failure, and on Ubuntu it made it through 735 successful runs with no failures before Actions shot the job for running too long. So I think that shows things are pretty rock solid now!