Skip to content

Fix Waiting for Load #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameskerr merged 1 commit into from
Jan 26, 2024
Merged

Fix Waiting for Load #2991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/zui/src/domain/loads/operations/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ export const submit = createOperation(
const pool = await createPool(data)
const script = new ZedScript(data.shaper || "")
// Async so that we can return this and subscribe to updates on the load.
const promise = zui.pools
// Do not wait for the load to finish in this operation.
zui.pools
.load({
windowId: data.windowId,
format: data.format,
Expand All @@ -36,8 +37,6 @@ export const submit = createOperation(
})

zui.window.openTab(poolPath(pool.id))

return promise
}
)

Expand Down