Skip to content

Remove node-pipe dependency #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Jan 8, 2024
Merged

Remove node-pipe dependency #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/zui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@
"dependencies": {
"keytar": "^7.7.0"
},
"optionalDependencies": {
"node-pipe": "^0.1.1"
},
"devDependencies": {
"@babel/core": "^7.17.9",
"@brimdata/zed-js": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion apps/zui/scripts/esbuild.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const context = await esbuild.context({
platform: "node",
sourcemap: true,
target: "node16",
external: ["keytar", "electron", "node-pipe"],
external: ["keytar", "electron"],
tsconfig: "./tsconfig.json",
})

Expand Down
6 changes: 2 additions & 4 deletions packages/zed-node/src/lake.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,12 @@ export class Lake {
stdio: ['inherit', 'inherit', 'inherit'],
windowsHide: true,
};
// For unix systems, pass posix pipe read file descriptor into lake process.
// For unix systems, pass a pipe file descriptor into the lake process.
// In the event of Zui getting shutdown via `SIGKILL`, this will let lake
// know that it has been orphaned and to shutdown.

if (process.platform !== 'win32') {
// eslint-disable-next-line @typescript-eslint/no-var-requires
const { readfd } = require('node-pipe').pipeSync();
opts.stdio.push(readfd);
opts.stdio.push('pipe');
args.push(`-brimfd=${opts.stdio.length - 1}`);
}

Expand Down
23 changes: 0 additions & 23 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14264,15 +14264,6 @@ __metadata:
languageName: node
linkType: hard

"node-addon-api@npm:*":
version: 6.1.0
resolution: "node-addon-api@npm:6.1.0"
dependencies:
node-gyp: latest
checksum: 3a539510e677cfa3a833aca5397300e36141aca064cdc487554f2017110709a03a95da937e98c2a14ec3c626af7b2d1b6dabe629a481f9883143d0d5bff07bf2
languageName: node
linkType: hard

"node-addon-api@npm:^1.6.3":
version: 1.7.2
resolution: "node-addon-api@npm:1.7.2"
Expand Down Expand Up @@ -14359,16 +14350,6 @@ __metadata:
languageName: node
linkType: hard

"node-pipe@npm:^0.1.1":
version: 0.1.1
resolution: "node-pipe@npm:0.1.1"
dependencies:
node-addon-api: "*"
node-gyp: latest
conditions: (os=darwin | os=linux)
languageName: node
linkType: hard

"node-releases@npm:^2.0.13":
version: 2.0.13
resolution: "node-releases@npm:2.0.13"
Expand Down Expand Up @@ -19261,7 +19242,6 @@ __metadata:
msw: ^0.36.8
next: ^13.3.0
node-fetch: ^2.6.1
node-pipe: ^0.1.1
nodemon: ^2.0.22
npm-run-all: ^4.1.5
ohm-js: ^17.0.4
Expand Down Expand Up @@ -19303,8 +19283,5 @@ __metadata:
peerDependencies:
react: ^18.0.0
react-dom: ^18.0.0
dependenciesMeta:
node-pipe:
optional: true
languageName: unknown
linkType: soft