Skip to content

Conversation

@nwt
Copy link
Member

@nwt nwt commented Jan 7, 2024

Zui displays a Node exception if brimcap exits without reading its standard input to EOF. Display an error toast with details instead.

Update, here's how the branch looks now.

brimcap_error.mp4

Closes #2926

Zui displays a Node exception if brimcap exits without reading its
standard input to EOF.  Display an error toast with details instead.
@nwt nwt requested a review from jameskerr January 7, 2024 01:39
@philrz
Copy link
Contributor

philrz commented Jan 7, 2024

I tested out the branch with the pcap from #2926 (comment). The error presentation is improved enough that I'd consider this a fix for #2926.

image

@jameskerr jameskerr requested a review from philrz January 22, 2024 18:14
@philrz

This comment was marked as resolved.

@philrz
Copy link
Contributor

philrz commented Jan 22, 2024

@jameskerr: The e2e test looks good. FYI, I made a temporary branch based on this branch to which I merged main so I could have the knobs available in my improved e2e.yml. With that I did this Actions run that shows your e2e test running reliably on all OSes in CI.

At this point I think I'm good with this one merging, but since @nwt was already involved in this code and I know the Zui/Brimcap error channel has some complexities, I'd feel better if he had a chance to give it a 👍 first. I guess since he opened the PR he technically can't be the one to click "Approve" but I'll wait for him to give the word somewhere and then I'll do the clicking.

Copy link
Contributor

@philrz philrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwt and I talked offline and he didn't feel he had more to add to the review, so I'm hereby giving it the 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Error: write EPIPE" or "Error: write EPIPE" on attempted pcap import

4 participants