Fix Broken Title Bar Buttons #2953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
commented
Jan 5, 2024
| justify-content: center; | ||
| flex-shrink: 0; | ||
| transition: background 100ms; | ||
| -webkit-app-region: no-drag; |
Contributor
Author
There was a problem hiding this comment.
The app thought these buttons were draggable regions and intercepted all mouse events.
philrz
approved these changes
Jan 5, 2024
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the test! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buttons now work and there is an integration test that clicks all the buttons in the titlebar region and makes sure they work.
I'm not certain these tests would catch this bug, as it's outside of the scope of what playwright can test, but these tests still seem worthwhile.