-
Notifications
You must be signed in to change notification settings - Fork 70
Add ability to run manage from the serve command #5017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c310689 to
9e60962
Compare
This commit adds the ability to run zed manage in the same process as the zed serve command. If the -manage flag is set with a duration greater than 0 manage will run. This commit also move the manage package to lake/api/manage package and simplifies the logic for the monitor function.
9e60962 to
dad9f45
Compare
nwt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have @philrz give this a spin before we merge it.
Agreed. |
Co-authored-by: Noah Treuhaft <[email protected]>
|
I just tested this branch out at commit 9ce0f4f and it seems to work fine. One thing I found a little odd though is that I went looking for a ztest in this PR since that usually gives me a starting point for seeing how the new functionality is invoked and it looks like the only ztest change is to something that only exercises the pre-existing approach that used the |
|
@philrz yes |
This commit adds the ability to run zed manage in the same process as the zed serve command. If the -manage flag is set with a duration greater than 0 manage will run.
This commit also move the manage package to lake/api/manage package and simplifies the logic for the monitor function.