Skip to content

Update to support ivory-google-map refactor regarding psr/http* packages #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
evertharmeling wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update to support ivory-google-map refactor regarding psr/http* packages #33

evertharmeling wants to merge 6 commits into from

Conversation

@evertharmeling
Copy link

@evertharmeling evertharmeling commented Sep 8, 2025 •
edited
Loading

Changes after not relying on the php-http/message-factory package within ivory/google-map anymore:

  • Replaced Http\Message\MessageFactory with Psr\Http\Message\RequestFactoryInterface
  • Replaced Http\Client\HttpClient with Psr\Http\Client\ClientInterface
  • Dropped references to Httplug as it's not needed anymore with full PSR-17 and PSR-18 compatibility, also simplifies configuration.

Todo

  • Update docs
  • Update ivory/google-map version requirement after new release

Blocked by bresam/ivory-google-map#45

@evertharmeling evertharmeling marked this pull request as draft September 8, 2025 13:23
@ehymel
Copy link

ehymel commented Sep 8, 2025

Thank you for working on this!

@evertharmeling evertharmeling force-pushed the igm-refactor branch 3 times, most recently from 6dcbe4c to aa751f3 Compare September 8, 2025 18:30
@evertharmeling evertharmeling changed the title [WIP] Update to support ivory-google-map refactor regarding psr/http* packages Update to support ivory-google-map refactor regarding psr/http* packages Sep 8, 2025
@evertharmeling evertharmeling marked this pull request as ready for review September 8, 2025 18:32
@evertharmeling evertharmeling mentioned this pull request Sep 8, 2025
Open
@evertharmeling evertharmeling force-pushed the igm-refactor branch 8 times, most recently from d9a3b56 to 7bbf9e7 Compare September 8, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bresam bresam Awaiting requested review from bresam bresam is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evertharmeling @ehymel