Update readme with info on retroactively adding acts_as_list #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| - `list_item.lower_item` | ||
| - `list_item.lower_items` will return all the items below `list_item` in the list (ordered by the position, ascending) | ||
|
|
||
| ## Adding ActsAsList To An Existing Model |
Owner
There was a problem hiding this comment.
For consistency can you call it acts_as_list (use backticks)?
| - `list_item.lower_items` will return all the items below `list_item` in the list (ordered by the position, ascending) | ||
|
|
||
| ## Adding `acts_as_list` To An Existing Model | ||
| As it stands ActsAsList requires position values to be set on the model before the instance methods above will work. Adding something like the below to your migration will set the default position. Change the parameters to order if you want a different initial ordering. |
Owner
There was a problem hiding this comment.
This line needs to be swapped to acts_as_list also :)
Owner
|
Just that one tweak and I'll merge this for you :) |
Owner
|
@tinderfields, do you want to finish off that one change and I can close and merge this :) |
brendon
changed the title
Owner
|
I've taken your update and created my own commit on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.